Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OmegaConf.resolve() #639

Merged
merged 8 commits into from
Mar 24, 2021
Merged

Added OmegaConf.resolve() #639

merged 8 commits into from
Mar 24, 2021

Conversation

omry
Copy link
Owner

@omry omry commented Mar 23, 2021

Introduces OmegaConf.resolve()

Closes #640

@omry omry requested review from odelalleau and Jasha10 March 23, 2021 21:12
@omry omry changed the title added OmegaConf.resolve() Added OmegaConf.resolve() Mar 23, 2021
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect some issues

docs/source/usage.rst Outdated Show resolved Hide resolved
omegaconf/_impl.py Outdated Show resolved Hide resolved
omegaconf/_impl.py Show resolved Hide resolved
omegaconf/_impl.py Outdated Show resolved Hide resolved
tests/test_omegaconf.py Show resolved Hide resolved
@omry
Copy link
Owner Author

omry commented Mar 24, 2021

I am merging this to cut a dev release with it. Feedback is still welcome and if there are change requests I will handle in a followup PR.

@omry omry merged commit f7c2fe8 into master Mar 24, 2021
@omry omry deleted the resolve branch March 24, 2021 00:23
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues remain

omegaconf/_impl.py Show resolved Hide resolved
omegaconf/_impl.py Show resolved Hide resolved
omegaconf/_impl.py Show resolved Hide resolved
@omry omry mentioned this pull request Mar 24, 2021
Copy link
Owner Author

@omry omry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #642

omegaconf/_impl.py Show resolved Hide resolved
omegaconf/_impl.py Show resolved Hide resolved
omegaconf/_impl.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OmegaConf.resolve(cfg) : Resolves all interpolations in the given config object in-place
2 participants