Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydev.Debugger extension #607

Merged
merged 4 commits into from
Mar 16, 2021
Merged

Pydev.Debugger extension #607

merged 4 commits into from
Mar 16, 2021

Conversation

omry
Copy link
Owner

@omry omry commented Mar 16, 2021

Closes #214

See included doc for user facing description.

Example:
For this config:

simple = OmegaConf.create(
    {
        "a": "bar",
        "inter": "${a}",
        "inter2": "foo_${a}",
        "inter_error1": "${zzz}",
        "inter_error2": "foo_${zzz}",
        "missing": "???",
    },
)

Object inspection with USER flavor:
image

Object inspection with DEV flavor:
image

Object inspection with the resolver disabled (default behavior prior to extension):
image

@omry omry requested review from odelalleau and Jasha10 March 16, 2021 01:36
@omry omry changed the title Pydev plugin Pydev .Debugger plugin Mar 16, 2021
@omry omry changed the title Pydev .Debugger plugin Pydev.Debugger plugin Mar 16, 2021
@omry omry changed the title Pydev.Debugger plugin Pydev.Debugger extension Mar 16, 2021
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about Pydev.Debugger but overall looks good, just a few small comments

setup.py Show resolved Hide resolved
pydevd_plugins/extensions/pydevd_plugin_omegaconf.py Outdated Show resolved Hide resolved
pydevd_plugins/extensions/pydevd_plugin_omegaconf.py Outdated Show resolved Hide resolved
pydevd_plugins/extensions/pydevd_plugin_omegaconf.py Outdated Show resolved Hide resolved
tests/test_pydev_resolver_plugin.py Outdated Show resolved Hide resolved
tests/test_pydev_resolver_plugin.py Outdated Show resolved Hide resolved
tests/test_pydev_resolver_plugin.py Outdated Show resolved Hide resolved
tests/test_pydev_resolver_plugin.py Outdated Show resolved Hide resolved
tests/test_pydev_resolver_plugin.py Show resolved Hide resolved
@omry
Copy link
Owner Author

omry commented Mar 16, 2021

@fabioz, thanks for the plugin API!
It would be awesome if you can take a quick look and provide feedback.

@omry omry force-pushed the pydev-plugin branch 2 times, most recently from e577c92 to 9b7e079 Compare March 16, 2021 20:00
@odelalleau odelalleau self-requested a review March 16, 2021 21:10
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to VSCode debugger!

@omry omry merged commit e72ce68 into master Mar 16, 2021
@omry omry deleted the pydev-plugin branch March 16, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider implementing a pydev resolver plugin
2 participants