Improved handling of None values in node validation
#592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omry
reviewed
Mar 10, 2021
| def test_none_value_in_quoted_string(restore_resolvers: Any) -> None: | ||
| OmegaConf.register_new_resolver("test", lambda x: x) | ||
| cfg = OmegaConf.create({"x": "${test:'${missing}'}", "missing": None}) | ||
| assert cfg.x == "None" |
There was a problem hiding this comment.
okay, so quoting an interpolation is equivalent to casting the resolved value to a string?
There was a problem hiding this comment.
Yes. To clarify, there are two situations:
- The interpolation is exactly surrounded by quotes (
"${...}") => we resolve it normally but cast the result to string. - There are other characters around the interpolation (
"hello ${...} and hi") => this is strictly equivalent to regular string interpolations
I think this is the most intuitive behavior.
No user-facing bug that I know of. This is why it was originally part of #578 after the interpolation type validation (because it was fixing bugs there) This PR still adds some tests of |
Jasha10
requested changes
Mar 10, 2021
Co-authored-by: Jasha10 <[email protected]>
Co-authored-by: Jasha10 <[email protected]>
Jasha10
reviewed
Mar 10, 2021
Co-authored-by: Jasha10 <[email protected]>
Co-authored-by: Jasha10 <[email protected]>
Co-authored-by: Jasha10 <[email protected]>
omry
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts some of the changes from #578, related to the handling of
Nonevalues.Note that the test
test_none_value_in_quoted_stringadded here is not directly related to these changes (since it worked before this PR too), but it is good to have this test in before #578.