Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested flag_override now properly restore the orignal state #590

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Nested flag_override now properly restore the orignal state #590

merged 1 commit into from
Mar 9, 2021

Conversation

omry
Copy link
Owner

@omry omry commented Mar 9, 2021

Closes #589

@omry omry mentioned this pull request Mar 9, 2021
Closed
odelalleau
odelalleau approved these changes Mar 9, 2021
View reviewed changes
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@omry omry merged commit d9c3b01 into master Mar 9, 2021
@omry omry deleted the 589-nested-flag-override branch March 9, 2021 23:49
odelalleau pushed a commit to odelalleau/omegaconf that referenced this pull request Mar 10, 2021
@omry @odelalleau
Nested flag_override now properly restore the orignal state (omry#590)
4f9f826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odelalleau odelalleau odelalleau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flag_override() may not always restore the original flags
2 participants
@omry @odelalleau