Struct assign

[omry]

Fixes #586

[omry]

@odelalleau , take a second look.
Re-implemented as you suggested (see how easy that was? just give me a minimal repro :) ).
I also added some handling for ListConfig. I don't feel 100% confident I got everything covered but I think it's good for now unless you can spot an issue.

[Jasha10]

Earlier in Dictconfig._set_value_impl there is a code path that handles the case of is_structured_config(value):

            if is_structured_config(value):
                self._metadata.object_type = None
                data = get_structured_config_data(
                    value,
                    allow_objects=self._get_flag("allow_objects"),
                )
                for k, v in data.items():
                    self.__setitem__(k, v)
                self._metadata.object_type = get_type_of(value)

Do we need to worry about using flag_override for this code path?

[odelalleau]

Do we need to worry about using flag_override for this code path?

That's a good point, maybe the with flag_override() should come before the if block

[omry]

Do we need to worry about using flag_override for this code path?

Took a look. Indeed it was also needed to be in that code path.

That's a good point, maybe the with flag_override() should come before the if block

It's breaking a bunch of tests and I don't feel like digging.

[odelalleau]

Good for me!

Regarding:

It's breaking a bunch of tests and I don't feel like digging.

It may be related to the manipulation of flags in the DictConfig code path

[Jasha10]

Looks good to me too!