Code

Type validation of interpolations#578

Code

Merged

omry merged 22 commits intoomry:masteromry/omegaconf:masterfrom odelalleau:inter_validationodelalleau/omegaconf:inter_validationCopy head branch name to clipboardMar 13, 2021

+446-56

Commits

Commits on Mar 10, 2021

• Validate and convert interpolation results to their intended type

  Show description for 21224f2
  odelalleau

  committed
  21224f2

• Make ValueNode an abstract class

  Show description for 9923827
  odelalleau

  committed
  9923827

• Check if conversion is needed based on type rather than object identity

  odelalleau

  committed
  1749581

• Consistent exceptions when resolving interpolations

  Show description for a38eb8a
  odelalleau

  committed
  a38eb8a

• Set wrapped nodes as read-only

  odelalleau

  committed
  69a32d2

• Update news item according to suggestion

  odelalleau

  committed
  dca7e01

• Add news item to describe the new feature from omry#540

  odelalleau

  committed
  36167ba

• InterpolationResolutionError also inherits from ValidationError

  odelalleau

  committed
  6159f3e

• Add docstring for _resolve_interpolation_from_parse_tree()

  odelalleau

  committed
  3d350db

• Refactor: split _resolve_interpolation_from_parse_tree()

  odelalleau

  committed
  d09277d

Commits on Mar 11, 2021

• More accurate comment

  odelalleau

  committed
  a99f776

• Update tests/test_interpolation.py

  Show description for 0d63bf9
  

  odelalleau

  and

  omry

  authored
  0d63bf9

• Use a fixture instead of duplicating the identity resolver

  odelalleau

  committed
  c2c1c03

• Add comment to explain test

  odelalleau

  committed
  4af8eb5

• Clearer test names

  odelalleau

  committed
  804845f

Commits on Mar 12, 2021

• Move cast resolver to fixture in interpolation tests

  odelalleau

  committed
  96e55f3

• Add comment to explain test

  odelalleau

  committed
  b9a3197

• Check readonly flag directly

  odelalleau

  committed
  fefffc1

• Update tests/test_interpolation.py

  Show description for 5080322
  

  odelalleau

  and

  omry

  authored
  5080322

• Check readonly flag for dict/list resolver outputs

  odelalleau

  committed
  572e125

• Fix syntax error

  odelalleau

  committed
  ce92f60

• Remove now redundant definition of cast()

  odelalleau

  committed
  57ee921