Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support and deprecate empty args #571

Merged
merged 3 commits into from
Mar 2, 2021
Merged

Support and deprecate empty args #571

merged 3 commits into from
Mar 2, 2021

Conversation

odelalleau
Copy link
Collaborator

@odelalleau odelalleau commented Feb 26, 2021

Fixes #572

Copy link
Owner

@omry omry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are your tests? :)

omegaconf/grammar_visitor.py Show resolved Hide resolved
Copy link
Owner

@omry omry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@omry omry merged commit 8b78699 into omry:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation of empty resolver arguments in favor of explicit strings
2 participants