Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebook to synch with the docs #544

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

odelalleau
Copy link
Collaborator

@odelalleau odelalleau commented Feb 12, 2021

The main purpose is to get (almost) the same content in the docs and in the notebook.

There is also a minor change to the doc on node interpolation, to make
it clearer that we can use them as config objects (they are not plain
Python dictionaries).

There is also a minor change to the doc on node interpolation, to make
it clearer that we can use them as config objects (they are not plain
Python dictionaries).
@omry
Copy link
Owner

omry commented Feb 12, 2021

it's hard to review in the current form, but I didn't see a change removing the pytest usage.
pytest is not a runtime dependency of OmegaConf so it's not available in the binder by default. we should avoid using it in the example.

@odelalleau
Copy link
Collaborator Author

odelalleau commented Feb 12, 2021

it's hard to review in the current form, but I didn't see a change removing the pytest usage.

Right, this first PR was just to synch the docs. But I can include the pytest fix in it as well, will be done in a minute.
Edit: actually more in >1h, ran into a problem

@omry
Copy link
Owner

omry commented Feb 12, 2021

no rush.

@odelalleau
Copy link
Collaborator Author

Fixed the pytest / binder issue in 37e96d3

@omry omry merged commit ce485b5 into omry:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants