Unsafe merge #485
Merged
Unsafe merge #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #482
Add support for another variant of merge which is about 15 times faster in a benchmark.
The difference is that this version destroys the input configs, so it should only used if the input configs should not be used after the merge call.
It's working by not copying input nodes on set, this making the input configs inconsistent (their nodes parent no longer points to the original config, so interpolations and other things will fail for them.
Another difference than the normal merge is that this merge variant is merging directly into the first config node, eliminating the need for another whole deepcopy.
pytest benchmark/benchmark.py --benchmark-sort=name -k merge: