Code

Dict int key type#454

Code

Merged

omry merged 34 commits intoomry:masteromry/omegaconf:masterfrom 7iW:dict-int-key-typeCopy head branch name to clipboardDec 24, 2020

+230-91

Commits

Commits on Dec 10, 2020

• preliminary DictConfig support for int key type

  Jasha10

  committed
  1eadbdf

Commits on Dec 11, 2020

• DictConfig[int, ...]: comment out offending tests

  Jasha10

  committed
  29941b5

• black formatting

  Jasha10

  committed
  1848190

• black formatting

  Jasha10

  committed
  c4b12b9

• Merge branch 'dict-int-key-type' of https://github.com/7iW/omegaconf into dict-int-key-type

  Jasha10

  committed
  120ee32

Commits on Dec 13, 2020

• Change ErrorDictIntKey to ErrorDictObjectKey

  Show description for df962eb
  Jasha10

  committed
  df962eb

• tests: call OmegaConf.create on dictionary instead of string

  Show description for cbfed03
  

  Jasha10

  and

  omry

  authored
  cbfed03

• fix typo in test_basic_ops_dict

  Jasha10

  committed
  fec336c

• for invalid key test, use object instead of int

  Jasha10

  committed
  a3581c6

• Use DictKeyType instead of Union[...]

  Jasha10

  committed
  ecdef40

• add "DictKeyType" to __init__.__all__

  Jasha10

  committed
  56ea336

• Test Dict[int, str] in structured config

  Jasha10

  committed
  379b232

• black formatting

  Jasha10

  committed
  457ec4d

• More test coverage for Dict[int, ...]

  Jasha10

  committed
  181eaa5

• Use DictKeyType for type annotation.

  Show description for 2ef70e2
  Jasha10

  committed
  2ef70e2

Commits on Dec 14, 2020

• Change DictConfig MutableMapping parameter to Any.

  Show description for 3b193b6
  Jasha10

  committed
  3b193b6

• mypy: more flexible OmegaConf.create signature

  Jasha10

  committed
  a83120f

Commits on Dec 16, 2020

• modified: docs/source/structured_config.rst

  Jasha10

  committed
  4e056e6

• test Structured config extending Dict[int,str]

  Jasha10

  committed
  b9ab0bf

• test_basic_ops_dict.py: parametrize by key type

  Jasha10

  committed
  35c796a

• test OmegaConf.to_yaml for DictConfig[int, str]

  Jasha10

  committed
  c563e60

Commits on Dec 17, 2020

• update docs

  Jasha10

  committed
  2a700a5

• test_basic_ops_dict.py: add type annotations

  Jasha10

  committed
  819ad28

• mypy test_basic_ops_dict: more specific annotation

  Jasha10

  committed
  d5cdc18

• isort

  Jasha10

  committed
  d250253

• docs: explicit note about supported dict key types

  Jasha10

  committed
  0649b39

Commits on Dec 21, 2020

• Update docs/source/usage.rst

  Show description for 263d17e
  

  Jasha10

  and

  omry

  authored
  263d17e

• Update docs/source/usage.rst

  Show description for d330cb1
  

  Jasha10

  and

  omry

  authored
  d330cb1

• move DictKeyType defn basecontainer.py -> base.py

  Jasha10

  committed
  d50f2f2

• test KeyValidationError dict[int,Any]:mistyped_key

  Jasha10

  committed
  1c77264

• docs usage.rst: fix doctest failure

  Jasha10

  committed
  d6170a6

Commits on Dec 23, 2020

• add news fragment

  Jasha10

  committed
  9af1d0b

• Revert "add news fragment"

  Show description for fe0b0ad
  Jasha10

  committed
  fe0b0ad

• add towncrier news fragment

  Jasha10

  committed
  1ecd152