Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly crash when trying to access child of a value node #366

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Properly crash when trying to access child of a value node #366

merged 1 commit into from
Sep 10, 2020

Conversation

odelalleau
Copy link
Collaborator

Fix #364

NB: I didn't understand the motivation for the two lines I removed -- but tests still passed after removing them so I guess it should be ok :)

@omry
Copy link
Owner

omry commented Sep 10, 2020

Clearly there was motivation :)
I will take a look to see why it was.

omry
omry approved these changes Sep 10, 2020
View reviewed changes
Copy link
Owner

@omry omry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks like the sole purpose of this was to ensure the bad test passes :).

@omry omry merged commit 4b48373 into omry:master Sep 10, 2020
@odelalleau odelalleau deleted the fix_364 branch September 10, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omry omry omry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Using ${foo.bar} returns ${foo} if foo is not a container
2 participants
@odelalleau @omry