Make OmegaConf.select() consistent with cfg.get() regarding inter…

…polations to non-existing nodes

news/565.api_change

@@ -1,2 +1,2 @@
-Container methods `get()` and `pop()` do not return their default value anymore when the accessed key is an interpolation that cannot be resolved: instead, an exception is raised.
+`OmegaConf.select()` as well as container methods `get()` and `pop()` do not return their default value anymore when the accessed key is an interpolation that cannot be resolved: instead, an exception is raised.
 

omegaconf/omegaconf.py

@@ -733,7 +733,7 @@ def select(
                     throw_on_missing=throw_on_missing,
                     throw_on_resolution_failure=throw_on_resolution_failure,
                 )
-            except (ConfigKeyError, InterpolationKeyError):
+            except ConfigKeyError:
                 if default is not _EMPTY_MARKER_:
                     return default
                 else:

tests/test_select.py

@@ -7,6 +7,7 @@
 
 from omegaconf import MissingMandatoryValue, OmegaConf
 from omegaconf._utils import _ensure_container
+from omegaconf.errors import InterpolationKeyError
 
 
 @pytest.mark.parametrize("struct", [True, False, None])
@@ -64,7 +65,6 @@ def test_select(
     [
         pytest.param({}, "not_found", id="empty"),
         pytest.param({"missing": "???"}, "missing", id="missing"),
-        pytest.param({"inter": "${bad_key}"}, "inter", id="inter_bad_key"),
     ],
 )
 def test_select_default(
@@ -101,6 +101,20 @@ def test_select_default_throw_on_missing(
         OmegaConf.select(cfg, key, default=default, throw_on_missing=True)
 
 
+@pytest.mark.parametrize(
+    ["cfg", "key"],
+    [
+        pytest.param({"inter": "${bad_key}"}, "inter", id="inter_bad_key"),
+    ],
+)
+def test_select_default_throw_on_resolution_failure(cfg: Any, key: Any) -> None:
+    cfg = OmegaConf.create(cfg)
+
+    # throw on resolution failure still throws if default is provided
+    with pytest.raises(InterpolationKeyError):
+        OmegaConf.select(cfg, key, default=123, throw_on_resolution_failure=True)
+
+
 @pytest.mark.parametrize(
     ("cfg", "node_key", "expected"),
     [