Various fixes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, I don't understand all of the changes :-) Will still merge it. |
|
@oeufdure since the mozilla.org fork seems to have some activity now (importantly they merged the fix in #1) would you mind submitting this PR upstream? we may end up using upstream directly now that they've fixed that particular issue. |
|
@oeufdure I just updated the newest pkcs7 micromdm/scep#179 which has indefinite length BER form support. could you see if this addresses the first part this for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
since your repo is the reference for pkcs7 golang library for micromdm/scep, i give you some fixes i did to have intune scep working.
Fixes BER decode issue
Fixes PKCS7.Content issue (scep request coming from Intune are big and we need to append the content)
Set ContentEncryptionAlgorithm to EncryptionAlgorithmAES128CBC (With Intune android client EncryptionAlgorithmDESCBC fail)