Add documentation for highlight and fix bug #3282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the merge highlight issue: #2996
Problem
Consecutive highlights will automatically get merged into one.
The root cause is
useSelection.ts
)Changes
Visual Bug
Example sequence:
selection cursor ends at empty area, selecting no text at the focus node
create highlight (note: the word
share
is not selected)create another highlight, note the highlight overlap visual bug
removing one of highlight sometimes result in the patching to go wrong and jumble the source text#3165
The fix for this visual bug is to clip the selection to the preceding/succeeding DOM element by updating the selection range.
Testing
Manually tested