Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: resolve issues and warnings #3270

Merged

Conversation

remychantenay
Copy link
Contributor

@remychantenay remychantenay commented Dec 20, 2023

Resolving warnings and issues highlighted by Android Studio.

Examples:

  • Removed unused parameters.
  • Changed functions encapsulation level.
  • Removed unnecessary annotations.
  • Removed unused imports.

This might be painful and boring to review :)

Copy link

vercel bot commented Dec 20, 2023

@remychantenay is attempting to deploy a commit to the omnivore Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnivore-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 0:10am

@jacksonh
Copy link
Contributor

love pain

@jacksonh jacksonh merged commit b1dfa4d into omnivore-app:main Jan 3, 2024
2 of 4 checks passed
@remychantenay remychantenay deleted the android-cleanup-issues-and-warnings branch January 3, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants