Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop position trigger on labels table and sort labels by name returned by labels api #2915

Merged
merged 1 commit into from
Oct 12, 2023
Merged

drop position trigger on labels table and sort labels by name returned by labels api #2915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/api/src/resolvers/labels/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export const labelsResolver = authorized<LabelsSuccess, LabelsError>(
user: { id: uid },
},
order: {
position: 'ASC',
name: 'ASC',
},
})
})
Expand Down
10 changes: 10 additions & 0 deletions packages/db/migrations/0133.do.drop_position_trigger_ob_labels.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
-- Type: DO
-- Name: drop_position_trigger_ob_labels
-- Description: Drop increment_label_position and decrement_label_position trigger on omnivore.labels table

BEGIN;

DROP TRIGGER IF EXISTS increment_label_position ON omnivore.labels;
DROP TRIGGER IF EXISTS decrement_label_position ON omnivore.labels;

COMMIT;
17 changes: 17 additions & 0 deletions packages/db/migrations/0133.undo.drop_position_trigger_ob_labels.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
-- Type: UNDO
-- Name: drop_position_trigger_ob_labels
-- Description: Drop increment_label_position and decrement_label_position trigger on omnivore.labels table

BEGIN;

CREATE TRIGGER decrement_label_position
AFTER DELETE ON omnivore.labels
FOR EACH ROW
EXECUTE FUNCTION update_label_position();

CREATE TRIGGER increment_label_position
BEFORE INSERT ON omnivore.labels
FOR EACH ROW
EXECUTE FUNCTION update_label_position();

COMMIT;
Loading