Merge pull request #3235 from omnivore-app/increase-feed-limit

increase feed limit to 256

packages/api/src/resolvers/subscriptions/index.ts

@@ -223,7 +223,7 @@ export const subscribeResolver = authorized<
     }
 
     // create new rss subscription
-    const MAX_RSS_SUBSCRIPTIONS = 150
+    const MAX_RSS_SUBSCRIPTIONS = env.subscription.feed.max
     // validate rss feed
     const feed = await parseFeed(input.url)
     if (!feed) {
@@ -232,7 +232,7 @@ export const subscribeResolver = authorized<
       }
     }
 
-    // limit number of rss subscriptions to 150
+    // limit number of rss subscriptions to max
     const results = (await getRepository(Subscription).query(
       `insert into omnivore.subscriptions (name, url, description, type, user_id, icon, auto_add_to_library, is_private) 
           select $1, $2, $3, $4, $5, $6, $7, $8 from omnivore.subscriptions 
@@ -263,7 +263,7 @@ export const subscribeResolver = authorized<
     // create a cloud task to fetch rss feed item for the new subscription
     await enqueueRssFeedFetch({
       userIds: [uid],
-      url: input.url,
+      url: feed.url,
       subscriptionIds: [newSubscription.id],
       scheduledDates: [new Date()], // fetch immediately
       fetchedDates: [null],

packages/api/src/util.ts

@@ -104,6 +104,11 @@ interface BackendEnv {
   pocket: {
     consumerKey: string
   }
+  subscription: {
+    feed: {
+      max: number
+    }
+  }
 }
 
 /***
@@ -167,6 +172,7 @@ const nullableEnvVars = [
   'TRUST_PROXY',
   'INTEGRATION_EXPORTER_URL',
   'INTEGRATION_IMPORTER_URL',
+  'SUBSCRIPTION_FEED_MAX',
 ] // Allow some vars to be null/empty
 
 /* If not in GAE and Prod/QA/Demo env (f.e. on localhost/dev env), allow following env vars to be null */
@@ -303,6 +309,14 @@ export function getEnv(): BackendEnv {
     consumerKey: parse('POCKET_CONSUMER_KEY'),
   }
 
+  const subscription = {
+    feed: {
+      max: parse('SUBSCRIPTION_FEED_MAX')
+        ? parseInt(parse('SUBSCRIPTION_FEED_MAX'), 10)
+        : 256, // default to 256
+    },
+  }
+
   return {
     pg,
     client,
@@ -323,6 +337,7 @@ export function getEnv(): BackendEnv {
     azure,
     gcp,
     pocket,
+    subscription,
   }
 }