Obd #2
Merged
Obd #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark an invalid import
add mark to a possible invalide import: lnd does not have omnicore integrated.
mark a possible invalid import.
parseRequest: MUST test asset funding request, not just btc only.
unc openChannel: MUST test asset funding amount, not merely Bitcoin amount.
handle funding and funding acceptor: several place need to pay attention. For example, MUST check the asset amount(reserve) is within the Max-Min range. NOT only the bitcoin.
When the asset is bitcoin, this is the same to milli-satoshi, using 11 decimal, when the asset is omni-asset, this is a simple unsigned 64 int, 8 decimal when translats to string.
check it, may error if set 1
… && go test -run TestFundingManagerNormalWorkflow -v; \n cd routing && go test -run TestFindRoutesWithFeeLimit -v;
…s obto31:200m1pvjl...
fix a typo in comments of asset related cli
add comments on prefix "omni"，better use byte array directly to avoid capitalization, spaces, or other possible errors
…ested cmd openchannel
… to close ChannelPoint unsupported script type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the master is too old with upstream lightningnetwork/lnd
the pull request will upgrade to master-branch to lnd-v0.14.2-beta(Feb 4, 2022) ,
and add more omni-asset functions from obd.
Brief:
This release bases Omni-HTLC on the lnd commit and omnicore codebases. Where in omnicore, a new transaction type 7 is introduced to transfer multiple tokens of one property id to multiple receivers in Omnicore.
This release is a sub-project of OmniBOLT, and supports exclusive mode only, adding asset-aware interfaces and commands to lnd's gRPC API and CLI set.
The newly added API and commands are maintained in the following document:
https://omnilaboratory.github.io/obd/#/grpc-api
Environment
OS: Win10, Ubuntu 20.04
golang: 1.9
gcc: 9.3(for compiling Omnicore)
network: Regtest
Notes
Currently, supported functions are:
https://omnilaboratory.github.io/obd/#/grpc-api?id=list-of-asset-related-interfaces
The table listing the interfaces also compares the BTC-only lnd interfaces:
Integrators only need to specify an asset ID and amount in related lnd interfaces, when ID=0, it is bitcoin, when ID >=1, it is an omni asset.
What can you do?
Run Omnicore on Regtest mode, and then you can:
You can connect an obd node to all known lightning applications. But without customizing(minimum effort), these applications can only be aware of Bitcoin.
We also built docker images for easier drag-drop building your local OmniBolt lightning network by Polar(will release in Jun).
You MUST not: