Software Model Extension #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imallona
reviewed
Aug 27, 2024
| @@ -24,6 +24,14 @@ enums: | |||
| permissible_values: | |||
| S3: | |||
| text: S3 | |||
| SoftwareBackendEnum: | |||
There was a problem hiding this comment.
what about adding 'docker' too?
There was a problem hiding this comment.
perhaps even 'host' (as valid, even if discouraged, backend)
There was a problem hiding this comment.
Will add both, should we leave software_backend as a mandatory field in that case?
Making it optional and not filled would mean running it on the host ?
There was a problem hiding this comment.
I like mandatory - so we will always have the backend documented - logged, with the benchmark version and other specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.