👷 Appraisal: ActiveRecord 5 is the minimum supported version

omniauth · Nov 14, 2024 · a4a5ce2 · a4a5ce2
1 parent b015ac4
commit a4a5ce2
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 21 deletions.
diff --git a/.github/workflows/ancient.yml b/.github/workflows/ancient.yml
@@ -37,9 +37,6 @@ jobs:
           - '2.3.27'
         include:
           # Ruby 2.4
-          - ruby: "2.4"
-            appraisal: "ar-4-2"
-            taskname: "spec:orm:active_record"
           - ruby: "2.4"
             appraisal: "ar-5-0"
             taskname: "spec:orm:active_record"

diff --git a/Appraisals b/Appraisals
@@ -1,12 +1,5 @@
 # frozen_string_literal: true
 
-# Compat: Ruby >= 1.9.3
-# Test Matrix:
-#   - Ruby 2.4
-appraise "ar-4-2" do
-  gem "activerecord", "~> 4.2.11.3"
-end
-
 # Compat: Ruby >= 2.2.2
 # Test Matrix:
 #   - Ruby 2.4

diff --git a/Gemfile b/Gemfile
@@ -25,7 +25,6 @@ gem "rubocop-sequel"
 gem "standard", ">= 1.35.1"
 
 ### ORMs
-gem "activerecord", ">= 6", require: false # rails 6 requires Ruby 2.5 or later
 gem "couch_potato", "~> 1.17", require: false
 gem "mongoid", "~> 7", require: false
 gem "mongoid-rspec", "~> 4.2", require: false
@@ -43,7 +42,6 @@ gem "rb-fsevent"
 gem "kettle-soup-cover", "~> 1.0", ">= 1.0.2"
 
 ### Testing
-gem "anonymous_active_record", "~> 1", require: false
 gem "test-unit", ">= 3.0"
 
 platform :mri do

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -302,8 +302,8 @@ PLATFORMS
   x86_64-linux-musl
 
 DEPENDENCIES
-  activerecord (>= 6)
-  anonymous_active_record (~> 1)
+  activerecord (>= 5)
+  anonymous_active_record (~> 1.0, >= 1.0.9)
   appraisal (~> 2.5)
   byebug (>= 11)
   couch_potato (~> 1.17)

diff --git a/gemfiles/ar_4_2.gemfile b/gemfiles/ar_4_2.gemfile
diff --git a/omniauth-identity.gemspec b/omniauth-identity.gemspec
@@ -39,6 +39,8 @@ Gem::Specification.new do |spec|
   spec.add_dependency("version_gem", "~> 1.1", ">= 1.1.4")
 
   ### Testing
+  spec.add_development_dependency("activerecord", ">= 5")
+  spec.add_development_dependency("anonymous_active_record", "~> 1.0", ">= 1.0.9")
   spec.add_development_dependency("appraisal", "~> 2.5")
   spec.add_development_dependency("rack-test", "~> 1")
   spec.add_development_dependency("rake", "~> 13")