Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing case when check nonce error #651

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Missing case when check nonce error #651

merged 1 commit into from
Apr 8, 2022

Conversation

0xcuonghx
Copy link
Contributor

I found a missing case when checking the nonce error.

Error: "The tx doesn't have the correct nonce" not contained in isNonceError function so the nonce in Redis does not update so it is a loop error

ca26335d9543c0983b864d32f47d0026

@k1rill-fedoseev k1rill-fedoseev self-requested a review April 7, 2022 15:18
@k1rill-fedoseev k1rill-fedoseev changed the base branch from master to develop April 7, 2022 18:05
Copy link
Member

@k1rill-fedoseev k1rill-fedoseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, have you used Ganache in your environment? I didn't find this error in any other clients.

@0xcuonghx
Copy link
Contributor Author

I using my own company network and ropsten

@k1rill-fedoseev
Copy link
Member

I see, I am just curious what client are you using for your company private network and your HOME_RPC_URL setting? Common options might be Geth/Nethermind/Openethereum, but I don't see such error in them. I think such error is only present in the Ganache testing client, so I am asking if that is your case?

@0xcuonghx
Copy link
Contributor Author

Yeah. May because Ganache, I using ganache at first after that I switch to geth network(our network). May I ask you why happened at Ganache? And then you can close this pull

@k1rill-fedoseev
Copy link
Member

Different clients use different error messages, and while there are no uniformly accepted error codes for them, we need to stick to some particular error strings in our logic.
Here we have missed the error string that is exclusively used in Ganache, so thank you for adding that one.

@k1rill-fedoseev k1rill-fedoseev merged commit 4af882b into omni:develop Apr 8, 2022
akolotov added a commit that referenced this pull request Apr 29, 2022
This merge contains the following set of changes:
  * [Oracle, Fix] Add missing Ganache nonce error message (#651)
  * [ALM, Improvement] ALM: show manually added signatures (#653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants