Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execute message by safeExecuteSignaturesWithAutoGasLimit in ALM #573

Closed
akolotov opened this issue May 16, 2021 · 0 comments · Fixed by #586
Closed

execute message by safeExecuteSignaturesWithAutoGasLimit in ALM #573

akolotov opened this issue May 16, 2021 · 0 comments · Fixed by #586
Labels
ALM enhancement New feature or request

Comments

@akolotov
Copy link
Collaborator

Consider to modify behavior of ALM as so if a user press the "Execute" button, the application checks whether the Foreign AMB contract supports the safeExecuteSignaturesWithAutoGasLimit method (e.g. by comparison of the version of the contract) and uses this method instead of executeSignatures.
@akolotov akolotov added enhancement New feature or request ALM labels May 16, 2021
@k1rill-fedoseev k1rill-fedoseev mentioned this issue Jun 13, 2021
Merged
@akolotov akolotov mentioned this issue Jul 9, 2021
Merged
akolotov added a commit that referenced this issue Jul 10, 2021
@akolotov
Merge the develop branch to the master branch, preparation to v3.0.0-rc1
c92f80c 
This merge contains the following set of changes:
  * [Monitor, Improvement] Add statistics about used AMB information requests (#577)
  * [ALM, Improvement] Add safe-execute button in ALM (#580), closes #573, closes #551
  * [Oracle, Improvement] Improve confirm-relay feature (#582), closes #569
  * [Monitor, Fix] Prune print of long error messages about missing file (#579), closes #578
  * [Oracle, Fix] Use safe approach for eth_getLogs requests (#581)
  * [Oracle, Fix] Fix logging in gas price service (#583), closes #552
  * [Oracle, Fix] Fix oracle error patterns and oracle e2e tests (#585)
  * [Common, Other] Fix dependencies versions and update example.yml (#566)
  * [Common, Other] Upload services logs in e2e and ultimate tests (#568)
  * [Oracle, Other] added example of emergency shutdown controller contract (#572)
  * [Oracle, Other] Refactor oracle configuration (#584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ALM enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge the develop branch to the master branch, preparation to v3.0.0-rc1 omni/tokenbridge
1 participant
@akolotov