Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide interface to get the Fee Manager mode #148

Closed
akolotov opened this issue Jan 31, 2019 · 1 comment
Closed

Provide interface to get the Fee Manager mode #148

akolotov opened this issue Jan 31, 2019 · 1 comment
Assignees
Labels

Comments

@akolotov
Copy link
Collaborator

akolotov commented Jan 31, 2019

Related to Issue 119 Rewards for bridge validators.

As it was identified in omni/bridge-ui#182, there is a need to provide the Fee Manager mode similar we provide the bridge mode.

If the Fee Manager contains functionality to calculate and distribute the reward only for one-side directed transfer, the method should be defined as:

function getFeeManagerMode() public pure returns(bytes4 _data) {
    return bytes4(keccak256(abi.encodePacked("manages-one-direction")));
}

If the Fee Manager contains functionality to calculate and distribute the reward for transfers in both directions, the method should be defined as:

function getFeeManagerMode() public pure returns(bytes4 _data) {
    return bytes4(keccak256(abi.encodePacked("manages-both-directions")));
}

The corresponding wrappers should be provided on the bridge contracts side.

@akolotov
Copy link
Collaborator Author

Available in the release 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants