Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set SUPPRESS as the default value for add_subclass_arguments #90

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Set SUPPRESS as the default value for add_subclass_arguments #90

merged 2 commits into from
Sep 16, 2021

Conversation

carmocca
Copy link
Contributor

Fixes #83

This if will now work:

jsonargparse/jsonargparse/core.py

Line 951 in dde80fb

if action.default != SUPPRESS and action.dest != SUPPRESS:

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mauvilsa
mauvilsa approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@mauvilsa mauvilsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why I set the default to an empty dict. SUPPRESS does make more sense.

@mauvilsa mauvilsa merged commit c3e5c21 into omni-us:master Sep 16, 2021
@carmocca carmocca deleted the bugfix/83 branch September 16, 2021 08:14
@carmocca carmocca restored the bugfix/83 branch September 16, 2021 14:12
@carmocca carmocca deleted the bugfix/83 branch September 16, 2021 14:19
@carmocca carmocca mentioned this pull request Sep 24, 2021
Merged
12 tasks
@mauvilsa mauvilsa mentioned this pull request Jul 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauvilsa mauvilsa mauvilsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config check failed with add_subclass_arguments(required=False)
2 participants
@carmocca @mauvilsa