fix: make sure the field and matching pattern are ordered correctly #315
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @aristosvo thank you for the PR! |
aristosvo
force-pushed
the
fix/regex-pattern-match-error-msg
branch
from
7d238cf to
d0d44a1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 76.58% 73.17% -3.41%
==========================================
Files 24 43 +19
Lines 1892 2837 +945
==========================================
+ Hits 1449 2076 +627
- Misses 354 588 +234
- Partials 89 173 +84 ☔ View full report in Codecov by Sentry. |
|
Tests are passing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FieldName and FieldPattern were ordered wrong, confusing the users with a weird pattern error