Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KHR_audio #73

Merged
merged 9 commits into from
Aug 4, 2022
Merged

KHR_audio #73

merged 9 commits into from
Aug 4, 2022

Conversation

robertlong
Copy link
Member

@robertlong robertlong commented Mar 23, 2022

This PR proposes a number of changes discussed during the OMI/Khronos 3D Formats Working Group Meeting on 3/23/2022 with @robertlong, @fire, and @lyuma in attendance.

Khronos is eager to unify the MSFT_audio_emitter and OMI_audio_emitter extensions into a single common KHR extension.

Since OMI_audio_emitter is effectively a subset of the MSFT_audio_emitter features, there are no additional features to be added to OMI_audio_emitter. Only changes to how the JSON schema is defined, likely some clarifications to the spec in future PRs, and a change in extension name to reflect that this will be the official Khronos ratified extension.

Here are the changes to the schema:

  • The extension has been renamed from OMI_audio_emitter to KHR_audio. KHR_audio both reflects the intent for this to be an official Khronos ratified extension and a more general audio extension to form the basis for additional extensions to provide features such as audio mixing, animation/one shot triggering of clips, additional audio format support, etc.
  • audioEmitter / audioEmitters properties have been renamed to emitter/emitters. The audio prefix is redundant because these properties are nested under KHR_audio
  • Positional audio emitter properties are moved into the positional object. This object can be added to audio emitters when it is of type positional.
  • Fixed a typo in the schema where scenes defined their emitters property as nodes instead of emitters

We will discuss these changes in our weekly glTF Working Group meeting tomorrow and decide if we'd like to take this to a vote in the following meeting. If that passes, we'll go forward with submitting this as a PR to the Khronos repository.

@robertlong
Copy link
Member Author

robertlong commented Mar 31, 2022

The vote to approve submitting this proposal to Khronos and moving our efforts to a unified KHR extension has passed:
Screen Shot 2022-03-31 at 2 52 01 PM
Screen Shot 2022-03-31 at 2 51 13 PM
Screen Shot 2022-03-31 at 2 51 05 PM
Screen Shot 2022-03-31 at 2 51 25 PM
Screen Shot 2022-03-31 at 2 51 21 PM

@robertlong
Copy link
Member Author

Submitted to Khronos for review here: KhronosGroup/glTF#2137

@aaronfranke
Copy link
Member

Where can I find example glTF files that use KHR_audio?

@fire fire deleted the KHR_audio branch October 12, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants