-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KHR_audio #73
Merged
Merged
KHR_audio #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submitted to Khronos for review here: KhronosGroup/glTF#2137 |
Adjustments to KHR_audio PR recommendations to split audio out
Adjust name of sources.schema and makes new proper sources object schema
Where can I find example glTF files that use KHR_audio? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a number of changes discussed during the OMI/Khronos 3D Formats Working Group Meeting on 3/23/2022 with @robertlong, @fire, and @lyuma in attendance.
Khronos is eager to unify the MSFT_audio_emitter and OMI_audio_emitter extensions into a single common KHR extension.
Since
OMI_audio_emitter
is effectively a subset of theMSFT_audio_emitter
features, there are no additional features to be added toOMI_audio_emitter
. Only changes to how the JSON schema is defined, likely some clarifications to the spec in future PRs, and a change in extension name to reflect that this will be the official Khronos ratified extension.Here are the changes to the schema:
OMI_audio_emitter
toKHR_audio
.KHR_audio
both reflects the intent for this to be an official Khronos ratified extension and a more general audio extension to form the basis for additional extensions to provide features such as audio mixing, animation/one shot triggering of clips, additional audio format support, etc.audioEmitter
/audioEmitters
properties have been renamed toemitter
/emitters
. Theaudio
prefix is redundant because these properties are nested underKHR_audio
positional
object. This object can be added to audio emitters when it is of typepositional
.nodes
instead ofemitters
We will discuss these changes in our weekly glTF Working Group meeting tomorrow and decide if we'd like to take this to a vote in the following meeting. If that passes, we'll go forward with submitting this as a PR to the Khronos repository.