-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HexInput component #18
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9edceae
`HexInput` component
omgovich 7d4d3a6
Publish `HexInput` package to NPM
omgovich 9961451
Cover `HexInput` with tests
omgovich bb833af
Improve `HexInput` snapshot test
omgovich 59bb45a
Add comment to `HexInput` coomponent code
omgovich 13be095
Add `HexInput` to README
omgovich 540c39b
Update `HexInput` summary
omgovich a4ea719
Get rid of the spread operator polyfill
omgovich 227b920
Update size-limit settings
omgovich d59c6e6
Do not add `color` attr to `input`-tag
omgovich 17a026a
Update `Why react-colorful?` section
omgovich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ dist/ | |
/hsv | ||
/rgb | ||
/rgbString | ||
/HexInput | ||
|
||
# OSX | ||
.DS_Store | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
import React, { useState, useEffect, useCallback } from "react"; | ||
import validHex from "../utils/validHex"; | ||
|
||
// Escapes all non-hexadecimal characters including "#" | ||
const escape = (hex) => hex.replace(/([^0-9A-F]+)/gi, ""); | ||
|
||
const HexInput = (props) => { | ||
const { color, onChange } = props; | ||
const [value, setValue] = useState(escape(color)); | ||
|
||
// Trigger `onChange` handler only if the input value is a valid HEX-color | ||
const handleChange = useCallback( | ||
(e) => { | ||
const inputValue = escape(e.target.value); | ||
setValue(inputValue); | ||
if (onChange && validHex(inputValue)) onChange("#" + inputValue); | ||
}, | ||
[onChange] | ||
); | ||
|
||
// Take the color from props if the last typed color (in local state) is not valid | ||
const handleBlur = useCallback( | ||
(e) => { | ||
if (!validHex(e.target.value)) setValue(escape(color)); | ||
}, | ||
[color] | ||
); | ||
|
||
// Update the local state when `color` property value is changed | ||
useEffect(() => { | ||
setValue(escape(color)); | ||
}, [color]); | ||
|
||
// Spread operator replacement to get rid of the polyfill (saves 150 bytes gzipped) | ||
const inputProps = Object.assign({}, props, { | ||
color: null, // do not add `color` attr to `input`-tag | ||
value, | ||
maxLength: 6, | ||
spellCheck: "false", // the element should not be checked for spelling errors | ||
onChange: handleChange, | ||
onBlur: handleBlur, | ||
}); | ||
|
||
return React.createElement("input", inputProps); | ||
}; | ||
|
||
HexInput.defaultProps = { | ||
color: "", | ||
}; | ||
|
||
export default React.memo(HexInput); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
import HexInput from "../components/HexInput"; | ||
export default HexInput; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
const hex3 = /^#?[0-9A-F]{3}$/i; | ||
const hex6 = /^#?[0-9A-F]{6}$/i; | ||
|
||
const validHex = (color) => hex6.test(color) || hex3.test(color); | ||
|
||
export default validHex; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that's smart!