Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump version to 1.0.2, add CHANGELOG #582

Merged
merged 4 commits into from
Feb 17, 2020
Merged

Conversation

paulperegud
Copy link
Contributor

@paulperegud paulperegud commented Feb 13, 2020

Reason: we can't "unrelease". We point to 1.0.x version in other places.

See: #561

Also, see rollback discussion here: #580

[edit: we end up moving to 1.0.2 instead of 2.0.0]

@paulperegud paulperegud changed the title chore: bump version to 2.0.0 [DRAFT] chore: bump version to 2.0.0 Feb 13, 2020
@paulperegud paulperegud changed the title [DRAFT] chore: bump version to 2.0.0 [DRAFT] chore: bump version to 2.0.0, add CHANGELOG Feb 13, 2020
thec00n
thec00n previously approved these changes Feb 14, 2020
Copy link
Contributor

@thec00n thec00n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thec00n
Copy link
Contributor

thec00n commented Feb 14, 2020

Thanks for adding the changelog and let's use 1.0.2 as per chat.

@paulperegud paulperegud force-pushed the bump-version-to-2.0.0 branch from 2d93c46 to a82df3c Compare February 14, 2020 20:38
@paulperegud paulperegud changed the title [DRAFT] chore: bump version to 2.0.0, add CHANGELOG chore: bump version to 2.0.0, add CHANGELOG Feb 14, 2020
@paulperegud paulperegud requested a review from thec00n February 14, 2020 20:38
thec00n
thec00n previously approved these changes Feb 17, 2020
Copy link
Contributor

@thec00n thec00n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Show resolved Hide resolved
Co-Authored-By: Unnawut Leepaisalsuwanna <[email protected]>
@kevsul kevsul requested a review from thec00n February 17, 2020 09:01
Copy link
Contributor

@thec00n thec00n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, the PaymentInFlightExitRouter.inFlightExits sneaked in as well :)

@kevsul kevsul merged commit bfbf7cc into master Feb 17, 2020
@kevsul kevsul deleted the bump-version-to-2.0.0 branch February 17, 2020 09:29
@boolafish boolafish changed the title chore: bump version to 2.0.0, add CHANGELOG chore: bump version to 1.0.2, add CHANGELOG Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants