Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Upgrade to Elixir 1.6 #109

Merged
merged 5 commits into from
Mar 12, 2018
Merged

Upgrade to Elixir 1.6 #109

merged 5 commits into from
Mar 12, 2018

Conversation

unnawut
Copy link
Contributor

@unnawut unnawut commented Mar 12, 2018

Important: Preferably this PR should be merged at the same time as ewallet/goban's #9 so everyone using Goban can enjoy eWallet in Elixir 1.6 with us.


Issue/Task Number: T57

Overview

This PR upgrades eWallet to Elixir 1.6 along with necessary updates to the code and dependencies to support Elixir 1.6.

Changes

  • Upgrade the dependency ex_machina in ewallet_db and local_ledger_db to 037d826 which fixes the issue with Elixir 1.6
  • Upgrade rrene/credo to the latest master to support Elixir 1.6
  • Fix some test assertions as warned by the new version of rrene/credo
  • Upgrade Dockerfile to Elixir 1.6

Implementation Details

The upgrade replaces ex_machina's version with a reference commit because ex_machina hasn't released a new version yet despite requests #261 and #275.

Usage

Run mix deps.get then mix test. Tests should pass.

vagrant@ewallet:/vagrant$ elixir --version
Erlang/OTP 20 [erts-9.2] [source] [64-bit] [smp:1:1] [ds:1:1:10] [async-threads:10] [hipe] [kernel-poll:false]

Elixir 1.6.1 (compiled with OTP 19)

vagrant@ewallet:/vagrant$ mix test
==> local_ledger_db
.........................................................

Finished in 4.1 seconds
57 tests, 0 failures

Randomized with seed 716370
==> ewallet_db
..............................................................................................................................................................................................................................................................

Finished in 7.5 seconds
254 tests, 0 failures

Randomized with seed 716370
==> local_ledger
.........................

Finished in 2.2 seconds
25 tests, 0 failures

Randomized with seed 716370
==> ewallet
...............................................................................................................................................

Finished in 9.6 seconds
143 tests, 0 failures

Randomized with seed 716370
==> admin_api
........................................................................................................................................................................................

Finished in 12.0 seconds
184 tests, 0 failures

Randomized with seed 716370
==> ewallet_api
..........................................................................................................................................

Finished in 11.2 seconds
138 tests, 0 failures

Randomized with seed 716370
==> admin_panel
..

Finished in 0.07 seconds
2 tests, 0 failures

Randomized with seed 716370
==> url_dispatcher
......

Finished in 0.1 seconds
6 tests, 0 failures

Randomized with seed 716370

Impact

Usual deployment. No extra steps.

@unnawut
Copy link
Contributor Author

unnawut commented Mar 12, 2018

Turns out I need to upgrade credo & fix some tests from the latest credo too

@unnawut unnawut changed the title Upgrade ex_machina Upgrade ex_machina and Elixir 1.6 Mar 12, 2018
@unnawut
Copy link
Contributor Author

unnawut commented Mar 12, 2018

Done. Ready for review.

@unnawut unnawut changed the title Upgrade ex_machina and Elixir 1.6 Upgrade to Elixir 1.6 Mar 12, 2018
@unnawut unnawut merged commit 25fd3e7 into develop Mar 12, 2018
@unnawut unnawut deleted the t57-ex-machina branch March 12, 2018 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement 🚀 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants