Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] remove .github from npm pack #42

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Conversation

omgaz
Copy link
Owner

@omgaz omgaz commented Oct 10, 2022

This PR fixes the issue where github actions code was being published to NPM. This would have caused no immediate issues for the end-user but was packaging unnecessary code.

This PR fixes GitHub Actions CI failures since the last update by removing older versions of NodeJS in the lint step.

Note
Diffler still works on Node 10+; the bug was in the lint step within CI.

Also removed linting on multiple versions of Node. This was redundant and using up Github action credits.

@omgaz omgaz marked this pull request as ready for review October 10, 2022 23:29
@omgaz omgaz merged commit 8a854c0 into master Oct 10, 2022
@omgaz omgaz deleted the exlude-github-from-npm-package branch October 10, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant