-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
word additions #9
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: zyth <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these words are suitable to be added to the dictionary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dislike the addition of ortholog(ue), since it's a specialized word (specifically a scientific word) and these are typically not included to main dictionaries.
i do think it should be included to Vivi at some point, but, it has to be a part of a dictionary apart from the main one.
i can create a new dictionary file or something if we need to in the coming days to house words like these (see #11), but for this specific change, it's best if we remove those words
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of all of these words because while orthologue is a specialized word, it is a commonly used one with over 1M results (ref: Google search) and thereby should be included.
i don't want to allow ortholog(ue) in yet until we resolve those discussions at #10 - so it would be best to move those words into a different PR or issue for now, so that we can merge the rest now |
No description provided.