Pipeline Builds for Bhatkhande Fonts #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite convert script in Python, which is a lot better than the fontforge script. Add a Bhatkhande build script, and use it in the general build process. Amend the build script to take the Bhatkhande base font, then layer in a language, then use it to generate .UFO and .TTF files. The intermediate .SFD files are deleted, so as not to cause any confusion.
Now we start with a OmeBhatkhandeBase font, with the language-specific characters layered in. This Base font is a copy of OmeBhatkhandeEnglish, since that had the standard width of 1582 applied to all characters, even the unused ones.
Since 2.0 was already released a long time ago, as seen in the CHANGELOG.
This makes it easier to compare all relevant characters for Ome Bhatkhande across the different languages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates the Bhatkhande font organization to use a Base Bhatkhande layer, and then add the language specific elements on top of that, to allow for easy addition of new languages in the future.
The architecture now looks like this:
Here is a visual comparison of FontGoggles output to demonstrate no changes to the fonts pre- and post- pipeline change:
As an aside, the
convert.pescript has been replaced with aconvert.pyto consolidate all our scripting in Python.Closes #66
While the relevant characters are identical to before, the unused characters in the fonts have been changed. This is an artifact of an early stage divergence between Ome Bhatkhande Hindi and English. Ome Bhatkhande Hindi started off as a default font, with varying widths for different glyphs. This was standardized in Ome Bhatkhande English to be the set 1582 for all characters, even the missing ones. Since Ome Bhatkhande Punjabi was a copy of Hindi, that too had the varying glyph widths.
After much consideration, I decided to use Ome Bhatkhande English as the Base font, since all characters using the standard width of 1582 is better for monospacing. However, if there are existing documents with mistaken or spurious characters in Ome Bhatkhande Hindi or Punjabi, those documents may be affected by this change.