Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for Punajbi Font (For Gurmat Sangeet) #12

Closed
mbaljeetsingh opened this issue Jan 11, 2018 · 15 comments · Fixed by #21
Closed

Adding Support for Punajbi Font (For Gurmat Sangeet) #12

mbaljeetsingh opened this issue Jan 11, 2018 · 15 comments · Fixed by #21
Assignees

Comments

@mbaljeetsingh
Copy link
Contributor

Can you add the Punjabi font? As I want to write notations in Punajbi for Gurmat Sangeet and North India music.

I can help you with the Punjabi font creation. It will be very similar to Hindi Font.

@rajadain
Copy link
Contributor

Thanks for checking this project out! I don't know much about the Gurmat Sangeet tradition of writing music, can you show me some samples? Is it just the Bhatkhande style but with Punjabi characters instead of Hindi (or English)? If so the translation shouldn't be very difficult.

Still, I have very little attention to spare to this project at the moment. The source files are all here if you'd like to take a stab at it yourself and open a PR. Otherwise I may eventually get to it one day.

@mbaljeetsingh
Copy link
Contributor Author

Yes, it is Bhatkhande style with Punjabi Characters. Can you guide me where can I start, I'll give it a try?

@rajadain
Copy link
Contributor

I haven't had a chance to work on documentation properly (#1), and I apologize for that. This is a very condensed version:

  1. Download and install the free and open-source FontForge
  2. Use it to open the Bhatkhande Hindi SFD file. The UFO files exist for cross software compatibility, but SFD is the native Font Forge format.
  3. Pick a Gurmukhi font to get glyphs from, and ask the designer for permission to use it. It'd be great if you can find a free and open-source Gurmukhi font that allows its glyphs being reused explicitly, but it's always a good idea to get permission.
  4. Change the glyphs for s, r, g, m, p, d, n, [, ], ;, ', \, which covers the seven notes and mizrab-ke-bol (see complete list of characters)
    • Ensure that the octave, variant, meend, and dugun / tigun / etc modifiers still fit and don't collide with the splines
    • Ensure that each character's width is 1582 to maintain compatibility with the Hindi and English versions
    • Optionally change the numerals as well
  5. Save it under /ome-bhatkhande-punjabi/ as SFD
  6. Add documentation for the Punjabi font by making a copy of the Hindi one
  7. Open a PR. I'll review and generate the TTFs and make a new release.

Honestly, just typing that out makes me realize that this is a serious undertaking, and if you haven't edited fonts before it may be quite the challenge. If you can do 3 above, namely picking a font and getting permission from the designer to use it, and tell me which characters to use for the seven notes and the mizrab-ke-bol, I may be able to do the rest in a month or so.

@mbaljeetsingh
Copy link
Contributor Author

Hi @rajadain,

I have started adding the Gurmukhi/Punjabi support. I'm using the Gurmukhi Lipi Font, sent the mail to the owner regarding seeking permission, Hopefully he'll give the positive reply soon.

Currently I have added the s and r
Inkedfontforge_2019-12-27_11-44-48_LI
Can you confirm, If I'm on the right track?
Here's the punajbi sfd file
https://github.com/mbaljeetsingh/fonts/blob/master/bhatkhande/punjabi/OmeBhatkhandePunjabi.sfd

@rajadain
Copy link
Contributor

Yes that looks great! Let me know if you have any specific questions.

@mbaljeetsingh
Copy link
Contributor Author

#17 Added Punjabi font support, please have a look.

rajadain added a commit that referenced this issue Mar 1, 2020
Add Punjabi Font based on GurbaniLipi Font

Closes #12
@mbaljeetsingh
Copy link
Contributor Author

Hi @rajadain

Can you please share when you'll be able to merge the font?

@rajadain
Copy link
Contributor

Thanks for prodding Baljeet. Things have been crazy here with the Coronavirus, but I'll get to this soon.

Can you share more about how you're going to use this? Hopefully the TTFs unblocked you for that project. Of course we do want an official release soon as well.

@mbaljeetsingh
Copy link
Contributor Author

Yes, I can understand the situation regarding Covid-19.

I'm actually planning to build a web/mobile app for writing notations and the we can view the notation in english, hindi and punjabi. I did test locally with hindi/english.

Looking forward to the official release. Thanks.

@rajadain
Copy link
Contributor

That's so cool! Looking forward to it!

Sounds like you may need some sort of webfont support for that as well. I've just realized that we don't do webfont generation by default in this repo, and have been using an older version of the webfonts for the docs. I'll consider adding webfont generation, but may more likely do it by hand one time and switch to using that.

In the interim, I've been doing some general cleanup here. Will merge that in shortly.

@rajadain rajadain self-assigned this Mar 27, 2020
@rajadain
Copy link
Contributor

Created #19 for adding Webfonts for the docs site.

rajadain added a commit that referenced this issue Apr 4, 2020
Add Ome Bhatkhande Punjabi font

Follow up to #17. Closes #12.
@mbaljeetsingh
Copy link
Contributor Author

Glad to see it merged. Looking forward to using it inside my web app. Thanks

@rajadain
Copy link
Contributor

rajadain commented Apr 4, 2020

Yes, thank you for all your hard work on this, and your patience. The docs have been updated as well, and you can see the new details for web apps here: https://omenad.github.io/fonts/usage/#web.

Please let me know in new issues if there's any questions. And please let me know about your app when it's done!

@rajadain
Copy link
Contributor

rajadain commented Apr 4, 2020

And of course I discover a bug upon release: #24. Please wait for the next release before downloading for personal use. The webfonts will be updated automatically, so you can continue to use those.

@rajadain
Copy link
Contributor

rajadain commented Apr 4, 2020

Okay, 2.2.1 is now out. This is good to go!

@rajadain rajadain added this to Fonts Jul 22, 2024
@rajadain rajadain moved this to Done in Fonts Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants