Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed site-page-edit.js. #1981

Closed
wants to merge 1 commit into from

Conversation

Daniel-KM
Copy link
Contributor

No description provided.

@zerocrates
Copy link
Member

What's the bug?

@Daniel-KM
Copy link
Contributor Author

For the block Asset, the button may not work (the selector hidden shuold have a "]" and there may be annother .selector-asset on the page.

@zerocrates
Copy link
Member

Do you happen to know of a situation where there is another .selected-asset? Just so we can confirm the fix. Another block, presumably, perhaps from a module?

I'm wondering if we might want to tie this not just to sidebars generically but to the asset sidebar specifically, #asset-options.

@Daniel-KM
Copy link
Contributor Author

When i updated module Block Plus in March, it didn't work and it was the fix. Maybe it is useless now. I'm finishing upgrading the module, so i let you know on Monday if it is still needed.

@Daniel-KM
Copy link
Contributor Author

I updated the module and i don't need the class .sidebar-content any more for this. In previous version, the js was overridden.

@zerocrates
Copy link
Member

So, are you saying you no longer need that part of the PR? I'm happy to have it, though I'd probably prefer it as #asset-options .selected-asset if we're going to make a change there.

zerocrates added a commit that referenced this pull request Mar 28, 2023
Don't accidentally get any other .selected-asset than the one in the
asset-options sidebar.

(variation on the remaining bit of #1981)
@zerocrates zerocrates closed this Mar 28, 2023
zerocrates added a commit that referenced this pull request Jun 15, 2023
Don't accidentally get any other .selected-asset than the one in the
asset-options sidebar.

(variation on the remaining bit of #1981)

(cherry picked from commit 078653c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants