Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDFAB-1140] Test DENY app filtering rule via QER gating in STC #260

Merged
merged 12 commits into from
Mar 18, 2022
Merged

[SDFAB-1140] Test DENY app filtering rule via QER gating in STC #260

merged 12 commits into from
Mar 18, 2022

Conversation

daniele-moro
Copy link
Collaborator

@daniele-moro daniele-moro commented Mar 10, 2022 •
edited
Loading

Add step for app-filtering PFCP scenario, to test an app filtering rule with a closed gate in the QER.

Depends on:

daniele-moro
daniele-moro commented Mar 10, 2022
View reviewed changes
.env.stable Outdated Show resolved Hide resolved
daniele-moro
daniele-moro commented Mar 10, 2022
View reviewed changes
.env.stable Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #260 (9cb1f2c) into master (851bf93) will not change coverage.
The diff coverage is n/a.

❗ Current head 9cb1f2c differs from pull request most recent head a40bd9e. Consider uploading reports for the commit a40bd9e to get more accurate results

@@            Coverage Diff            @@
##             master     #260   +/-   ##
=========================================
  Coverage     41.34%   41.34%           
  Complexity      144      144           
=========================================
  Files            15       15           
  Lines          2194     2194           
  Branches        277      277           
=========================================
  Hits            907      907           
  Misses         1210     1210           
  Partials         77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851bf93...a40bd9e. Read the comment docs.

@daniele-moro daniele-moro changed the title Test DENY app filtering rule via QER gating in STC [SDFAB-1140] Test DENY app filtering rule via QER gating in STC Mar 14, 2022
daniele-moro
daniele-moro commented Mar 14, 2022
View reviewed changes
.env.stable Outdated Show resolved Hide resolved
@daniele-moro daniele-moro requested a review from pierventre March 16, 2022 15:20
@daniele-moro
Copy link
Collaborator Author

retest this please

2 similar comments
@daniele-moro
Copy link
Collaborator Author

retest this please

@daniele-moro
Copy link
Collaborator Author

retest this please

@daniele-moro
Copy link
Collaborator Author

retest this please

@daniele-moro daniele-moro merged commit 9f6895f into master Mar 18, 2022
@daniele-moro daniele-moro deleted the filter_with_gate branch March 18, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmanueleGallone EmanueleGallone EmanueleGallone left review comments

@pierventre pierventre pierventre approved these changes

@ccascone ccascone Awaiting requested review from ccascone

@charlesmcchan charlesmcchan Awaiting requested review from charlesmcchan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniele-moro @pierventre @EmanueleGallone