Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDFAB-1110] Add support for multiple application filters #60

Merged
merged 22 commits into from
Mar 28, 2022

Conversation

EmanueleGallone
Copy link
Contributor

@EmanueleGallone EmanueleGallone commented Mar 21, 2022

Introduce the ability to set multiple app-filters.

@EmanueleGallone EmanueleGallone marked this pull request as draft March 21, 2022 08:20
@EmanueleGallone EmanueleGallone force-pushed the multiple-apps branch 8 times, most recently from 111b306 to 4356023 Compare March 21, 2022 16:45
@EmanueleGallone EmanueleGallone marked this pull request as ready for review March 21, 2022 16:48
@EmanueleGallone
Copy link
Contributor Author

EmanueleGallone commented Mar 21, 2022

Max supported app-filters per UE session = SessionStep/2 because of PDR UL + DL

@EmanueleGallone EmanueleGallone changed the title Add support for multiple application filters [SDFAB-1110] Add support for multiple application filters Mar 22, 2022
internal/pfcpsim/server.go Show resolved Hide resolved
internal/pfcpsim/server.go Show resolved Hide resolved
internal/pfcpsim/server.go Outdated Show resolved Hide resolved
internal/pfcpsim/server.go Outdated Show resolved Hide resolved
internal/pfcpsim/helpers.go Outdated Show resolved Hide resolved
internal/pfcpsim/server.go Show resolved Hide resolved
internal/pfcpsim/server.go Outdated Show resolved Hide resolved
internal/pfcpsim/server.go Outdated Show resolved Hide resolved
internal/pfcpsim/server.go Show resolved Hide resolved
Copy link
Contributor

@daniele-moro daniele-moro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change, otherwise LGTM.

internal/pfcpsim/server.go Outdated Show resolved Hide resolved
internal/pfcpsim/server.go Outdated Show resolved Hide resolved
internal/pfcpsim/server.go Outdated Show resolved Hide resolved
internal/pfcpsim/server.go Outdated Show resolved Hide resolved
@daniele-moro
Copy link
Contributor

We should be ready to merge: https://gerrit.onosproject.org/c/OnosSystemTest/+/25428 before merging this.

@daniele-moro daniele-moro merged commit 64474e9 into omec-project:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants