fix: observe GRPC client #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gab-arrobo
reviewed
Oct 21, 2024
There was a problem hiding this comment.
I see that changes are not consistent across the different NFs (in some NFs the updateConfig is in service/init.go like this in NF/PR and in other NFs, the same function goes in factory/factory.go). Would this be a good time to make the change consistent across all NFs?
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
gatici
force-pushed
the
TELCO-1381-recover-grpc-connection
branch
from
5a3c110 to
28bfc1f
Compare
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
gab-arrobo
approved these changes
Oct 26, 2024
| client := gClient.ConnectToConfigServer(factory.AmfConfig.Configuration.WebuiUri) | ||
| configChannel := client.PublishOnConfigChange(true) | ||
| go amf.UpdateConfig(configChannel) | ||
| logger.InitLog.Infoln("Reading Amf related configuration from ROC") |
There was a problem hiding this comment.
Suggested change
| logger.InitLog.Infoln("Reading Amf related configuration from ROC") | |
| logger.InitLog.Infoln("reading Amf related configuration from ROC") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve GPRC client connection issues which appears when GPRC server (webconsole) is restarted.
If the Webconsole is restarted, other modules loses the GRPC connection to Webconsole
They tries to connect again for hours with no success.
2024-09-26T11:32:10.014Z [smf] 2024-09-26T11:32:10Z [ERRO][Config5g][GRPC] Connectivity status idle, trying to connect again
NF observes the GRPC client availability and connection status in an infinite loop.
If the connection is ready it does nothing. If GRPC client does not exist, it creates new client. If GRPC client connection is not ready, it closes the existing client and creates another client.
Only one GRPC client exists for any time slot.