-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for the omero.logging properties #6393
Conversation
All these properties are defined in OMERO.py so changing the default value in this file has no effect but allows for the configuration to be included in the reference documentation
Looks good. Text makes sense. So this PR is purely to update the docs at https://omero.readthedocs.io/en/latest/sysadmins/config.html? |
d3f24f5
to
b73a17c
Compare
Absolutely, the default logging values are defined in https://github.com/ome/omero-py/blob/8d8108de02104c654741d65f0ecbbf11c85e329d/src/omero/util/__init__.py#L32-L38 so modifying But it is currently undocumented that the server logs can be configured using the standard
Pushed b73a17c to use the current lowercase convention consistently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
While using these properties as part of the review of ome/omero-py#417, one important aspect worth noting is that the The last commit should update the property description to be explicit about this. |
Initial step towards fixing #6225
All these properties are defined in OMERO.py so changing the default value in this file has no effect but allows for the configuration to be included in the reference documentation