Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove slice2java #6325

Merged
merged 7 commits into from
Jun 27, 2022
Merged

remove slice2java #6325

merged 7 commits into from
Jun 27, 2022

Conversation

jburel
Copy link
Member

@jburel jburel commented Jun 10, 2022

Remove slice2java.
Check that the build is green

@jburel jburel requested a review from sbesson June 10, 2022 10:08
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the build passes without issue with this PR included, both in the GitHub Actions context as well as locally (without slice2java installed), the server failed to start - see https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-server/1234/

Looking quickly at the logs, the services did not get started. Looking at a few configuration files, il looks like a few variables did not get subsituted e.g. in etc/omero.properties:

omero.version=5.6.3-242-d748290-ice${versions.ice_lib}-b1224

@jburel
Copy link
Member Author

jburel commented Jun 10, 2022

Since we are using only one ice version, that could be removed.

@jburel jburel removed the exclude label Jun 15, 2022
@jburel
Copy link
Member Author

jburel commented Jun 16, 2022

Back to green https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-server/1242/ with this PR included

@sbesson
Copy link
Member

sbesson commented Jun 17, 2022

OMERO.script integration tests (Python + Java) have been failing for the last two days - see https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/1137/. This is possibly related to these changes

@jburel
Copy link
Member Author

jburel commented Jun 22, 2022

@sbesson
Copy link
Member

sbesson commented Jun 22, 2022

In general, 👍 for getting rid of the unnecessary slice2java dependency for building.

The biggest change looking at the nightly artifacts is the removal of the -ice36 suffix from omero.version and hence the OMERO.server artifact name.

This raises essentially the same question as in #6318 (comment). Do we have an authoritative list of all the downstream locations that would be impacted by the change and will need to be reviewed? And do you have a feeling of the cost/time of updating these post server release?

@joshmoore
Copy link
Member

Briefly:

  • I don't have an idea of what impact dropping -ice36 might have.
  • Is slice2py still needed?

@jburel
Copy link
Member Author

jburel commented Jun 22, 2022

  • omego and the ansible roles are the ones to review.
    I have rolled back the name change. This does not need to be included in that body of work.

@jburel
Copy link
Member Author

jburel commented Jun 22, 2022

@joshmoore I think we can also drop slice2py to build
I have run ./build.py clean && ./build.py in a conda environment without slice2py and it works fine.
The question is: do we want to have env to build only and env to run only?

@jburel
Copy link
Member Author

jburel commented Jun 22, 2022

The last 2 commits remove:

  • slice2py
  • ice-action

the build remains green

@jburel jburel mentioned this pull request Jun 22, 2022
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the latest version of this PR feels like the minimal set of changes allowing to drop the unnecessary Ice requirement at the level of this repository without modifying artifact names and downstream consumptions.

No objection to merging from my side

@sbesson sbesson requested a review from joshmoore June 24, 2022 13:54
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also no objections. I imagine eventually, we strip out the rest of strip2cpp, etc. but happy to wait until we drop ant & ivy 😄

@sbesson sbesson merged commit 147ca85 into ome:develop Jun 27, 2022
@jburel jburel deleted the slice2java branch March 10, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants