Bugfix: Set StringColumn to the correct size #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that the comment in the header of this PR should say Tested with a short code snippet from #75 - see screenshot below
The smaller table was created with this PR, the bigger (243 KB) without this PR. Lgtm |
pwalczysko
approved these changes
Jun 13, 2023
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75 .
Tested with the idr0115 annotations. "Test" table created with the same bulk_annotations without PR. "Test_2" table created with the PR (same size as the original).