-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to get PlaneInfos #57
Conversation
I can't compile/run the integration tests locally any longer, so I can't add any. But here's some example test code (using Image id 83221 which has some PlaneInfos):
|
Now that you can run the tests locally. Will you add a test? |
Will do. A problem could be to create an image with PlaneInfos in the test environment. But I'll have a look. |
I wrote a Python script for idr0113 to populate plane info (parse_time.py) |
try { | ||
ParametersI p = new ParametersI(); | ||
p.addLong("id", pix.getId()); | ||
List<IObject> planeinfos = gateway.getQueryService(ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be declared in IMetadata.ice (blitz) and implemented in omero-server as we have done with other similar method calls.
This could be done in a follow-up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to capture that in an issue since I think both Python and JAva will benefit from having such method instead o directly using IQuery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true. Issue created.
Tests in ome/openmicroscopy#6285 are green |
Add a similar method to the copyPlaneInfo method of Python BlitzGateway. Should fix #54 .
Todo:
Still needs integration test.Done