Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that dask input images are never computed #334

Closed
wants to merge 1 commit into from
Closed

Clarify that dask input images are never computed #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ome_zarr/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,8 @@ def write_image(
option.
:param compute:
If true compute immediately otherwise a list of :class:`dask.delayed.Delayed`
is returned.
is returned. If the input image is a dask Array this argument is ignored and
a list of :class:`dask.delayed.Delayed` is always returned.
:return:
Empty list if the compute flag is True, otherwise it returns a list of
:class:`dask.delayed.Delayed` representing the value to be computed by
Expand All @@ -507,7 +508,6 @@ def write_image(
coordinate_transformations=coordinate_transformations,
storage_options=storage_options,
name=None,
compute=compute,
**metadata,
)
else:
Expand Down Expand Up @@ -551,7 +551,6 @@ def _write_dask_image(
coordinate_transformations: Optional[List[List[Dict[str, Any]]]] = None,
storage_options: Optional[Union[JSONDict, List[JSONDict]]] = None,
name: Optional[str] = None,
compute: Optional[bool] = True,
**metadata: Union[str, JSONDict, List[JSONDict]],
) -> List:
if fmt.version in ("0.1", "0.2"):
Expand Down