Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer names #36

Closed
constantinpape opened this issue Mar 16, 2022 · 4 comments · Fixed by ome/ome-zarr-py#214
Closed

Layer names #36

constantinpape opened this issue Mar 16, 2022 · 4 comments · Fixed by ome/ome-zarr-py#214

Comments

@constantinpape
Copy link

Currently, the filename is used to determine the layer names:
image
I think it would be better to use the "name" field from the multiscale spec instead (if it's given).
This would make the layers easier to distinguish.

@constantinpape
Copy link
Author

Fyi, I noticed that this works for some other ome.zarr files, i.e. the name field is used for the layers.
However, it does not wok for this data https://oc.embl.de/index.php/s/wfpdHpgHseGUTYK, which has a few other issues as well (#37, #35).
It would be important to understand if this is a problem with the data (which is produced with this script using ome-zarr-py) or the napari plugin (or both :D)

@constantinpape
Copy link
Author

constantinpape commented Mar 17, 2022

After fixing the issue with the image-label field this looks a bit different now:
image
It uses the filename for the image data and the name field for the label data. I think that it should use the name field for all of the layers (if it is given, which is the case here; it's image for the image data).
The new data is available here:
https://oc.embl.de/index.php/s/zsg7aHyg1R7aFgh

@constantinpape
Copy link
Author

@will-moore
Copy link
Member

Should be fixed by ome/ome-zarr-py#214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants