Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels should be opened as label layer #35

Closed
constantinpape opened this issue Mar 15, 2022 · 4 comments
Closed

Labels should be opened as label layer #35

constantinpape opened this issue Mar 15, 2022 · 4 comments

Comments

@constantinpape
Copy link

After fixing the issues with my data observed in #33. The labels are now loaded by the plugin.
However they are loaded as image layer:
image

It would make more sense to load them as label layer instead. Note that this is particularly annoying right now since it's not possible to convert them into a label layer due to #34.

@will-moore
Copy link
Member

Can you try napari https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.3/idr0079A/9836998.zarr, which is an example with labels that show up as labels for me.
Can you share the data you're viewing above?

@constantinpape
Copy link
Author

Can you try napari https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.3/idr0079A/9836998.zarr, which is an example with labels that show up as labels for me.

Yes, that opens it as labels layer for me too.

Can you share the data you're viewing above?

I uploaded the data here: https://oc.embl.de/index.php/s/wfpdHpgHseGUTYK. It is from the example here: https://github.com/ome/ome-ngff-prototypes/tree/main/workflows/spatial-transcriptomics-example

@constantinpape
Copy link
Author

I found the likely culprit: ome/ngff#109
(I have used snake case, i.e. image_label.) Will double check this now.

@constantinpape
Copy link
Author

Yes, this fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants