-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API to support sub-resolutions #118
Conversation
This reduces the number of (slow) calls to isThisType that are needed.
Removes debugging statements and a few unnecessary method calls.
This has the advantage of reducing memory requirements by an order of magnitude, with what is in my measurements minimal time penalty.
Testing with test_images_good, there were 23 commit test failures: /ome/data_repo/test_images_good/Cell Sens/anda/Image_01_V76 K2 11_lung.vsi: /ome/data_repo/test_images_good/cellworx/hms/plate1/plate1.HTD: Initializing /ome/data_repo/test_images_good/pyramid/101_pyramid: Just repo configuration issues for most of these? |
The testValidXML failure is fixed on a different branch. Everything else should be working if you're testing against the latest origin/develop with sub-resolutions merged in. |
Merged into current develop, all tests pass with zero failures. |
Add API to support sub-resolutions
Web templates 7392
Pyramid TIFF: parse OME-XML comment if present
With this branch, each series can now have a pyramid of sub-resolution series associated with it.
The new methods in IFormatReader are:
Affected readers have data in the following directories:
There is also a new test (loci.tests.testng.SubResolutionTest) which will be added to Jenkins once this PR is merged.