Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to support sub-resolutions #118

Merged
merged 22 commits into from
Aug 16, 2012

Conversation

melissalinkert
Copy link
Member

With this branch, each series can now have a pyramid of sub-resolution series associated with it.

The new methods in IFormatReader are:

  • setFlattenedResolutions(boolean) (controls whether or not the resolution hierarchy is respected)
  • hasFlattenedResolutions() (true by default; whether or not the resolution hierarchy is respected)
  • int getResolutionCount() (the number of sub-resolutions for the current series)
  • setResolution(int) (sets the current sub-resolution for the current series)
  • int getResolution() (gets the current sub-resolution for the current series)

Affected readers have data in the following directories:

  • cellsens
  • imaris
  • jpeg2000
  • ome-tiff
  • tiff
  • svs
  • test_images_good

There is also a new test (loci.tests.testng.SubResolutionTest) which will be added to Jenkins once this PR is merged.

melissalinkert and others added 22 commits July 26, 2012 17:01
This reduces the number of (slow) calls to isThisType that are needed.
Removes debugging statements and a few unnecessary method calls.
This has the advantage of reducing memory requirements by an order of
magnitude, with what is in my measurements minimal time penalty.
@ghost
Copy link

ghost commented Aug 10, 2012

Testing with test_images_good, there were 23 commit test failures:

/ome/data_repo/test_images_good/Cell Sens/anda/Image_01_V76 K2 11_lung.vsi:
SizeX: FAILED (Series 0)
/SizeY: FAILED (Series 0)

/ome/data_repo/test_images_good/cellworx/hms/plate1/plate1.HTD:
testPixelsHashes: FAILED (series 0)
testSubimagePixelsHashes: FAILED (series 0)
/ome/data_repo/test_images_good/dv/CFPNEAT01_R3D.dv:
testPixelsHashes: FAILED (series 0)
testSubimagePixelsHashes: FAILED (series 0)
/ome/data_repo/test_images_good/dv/IAGFP-Noc01_R3D.dv:
testPixelsHashes: FAILED (series 0)
testSubimagePixelsHashes: FAILED (series 0)
/ome/data_repo/test_images_good/dv/SMN10ul03_R3D_D3D.dv:
testPixelsHashes: FAILED (series 0)
testSubimagePixelsHashes: FAILED (series 0)
/ome/data_repo/test_images_good/dv/lung-lentiCMtriple-4_R3D.dv:
testPixelsHashes: FAILED (series 0)
testSubimagePixelsHashes: FAILED (series 0)
/ome/data_repo/test_images_good/dv/mt1_R3D_D3D.dv:
testPixelsHashes: FAILED (series 0)
testSubimagePixelsHashes: FAILED (series 0)
/ome/data_repo/test_images_good/dv/off_by_1_a.dv:
testPixelsHashes: FAILED (series 0)
testSubimagePixelsHashes: FAILED (series 0)
/ome/data_repo/test_images_good/dv/test11_R3D.dv:
testPixelsHashes: FAILED (series 0)
testSubimagePixelsHashes: FAILED (series 0)
/ome/data_repo/test_images_good/dv/very_small.d3d.dv:
testPixelsHashes: FAILED (series 0)
testSubimagePixelsHashes: FAILED (series 0)
/ome/data_repo/test_images_good/dv_single/test11_R3D.dv:
testPixelsHashes: FAILED (series 0)
testSubimagePixelsHashes: FAILED (series 0)

Initializing /ome/data_repo/test_images_good/pyramid/101_pyramid:
testValidXML: FAILED ()

Just repo configuration issues for most of these?

@melissalinkert
Copy link
Member Author

The testValidXML failure is fixed on a different branch. Everything else should be working if you're testing against the latest origin/develop with sub-resolutions merged in.

joshmoore added a commit to joshmoore/bioformats that referenced this pull request Aug 15, 2012
@ghost
Copy link

ghost commented Aug 15, 2012

Merged into current develop, all tests pass with zero failures.

chris-allan added a commit that referenced this pull request Aug 16, 2012
@chris-allan chris-allan merged commit e43da67 into ome:develop Aug 16, 2012
hflynn pushed a commit to hflynn/bioformats that referenced this pull request Oct 11, 2013
melissalinkert pushed a commit to melissalinkert/bioformats that referenced this pull request Jan 11, 2018
Pyramid TIFF: parse OME-XML comment if present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants