Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two DeprecationWarnings #150

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Fix two DeprecationWarnings #150

merged 2 commits into from
Oct 1, 2024

Conversation

npt
Copy link
Contributor

@npt npt commented Sep 30, 2024

  • verify_ssl is deprecated in favor of ssl since aiohttp 3.0
  • get_event_loop's behavior of creating an event loop if there isn't one running is deprecated in Python 3.12

npt added 2 commits September 30, 2024 14:21
@npt
Use ssl= instead of deprecated verify_ssl= when making aiohttp request
798cbdd 
This prevents a DeprecationWarning from being printed when using GCE instance credentials.
@npt
Use asyncio.run in test to avoid a DeprecationWarning from get_event_…
443804c 
…loop()
@omarryhan omarryhan merged commit 0287489 into omarryhan:master Oct 1, 2024
8 checks passed
@omarryhan
Copy link
Owner

Thanks!! Released in 5.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npt @omarryhan