Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add paystar gateway #18

Merged
merged 32 commits into from
Oct 23, 2023
Merged

Add paystar gateway #18

merged 32 commits into from
Oct 23, 2023

Conversation

majidfeiz
Copy link
Contributor

Added PayStar driver
Added PayStar config file
Update documentations

omalizadeh
omalizadeh reviewed Oct 9, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
omalizadeh
omalizadeh requested changes Oct 9, 2023
View reviewed changes
Copy link
Owner

@omalizadeh omalizadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check paystar doc carefully

@majidfeiz
Copy link
Contributor Author

  • secret use for generate sign but sign is not required it's optional and now user can use if need.
  • changed pin to gateway_id
  • complete status array
  • used withToken on Http facade instead of passing header
  • changed PHP version to 8.1

omalizadeh
omalizadeh requested changes Oct 12, 2023
View reviewed changes
Copy link
Owner

@omalizadeh omalizadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments

@omalizadeh
Copy link
Owner

OK, thanks for PR. please fix errors on action (styles) then we can merge it. @majidfeiz

@majidfeiz
Copy link
Contributor Author

I fixed the code style, please merge again, @omalizadeh.

@omalizadeh
Copy link
Owner

Still not passing style check. use php cs fixer to automatically fix styles and commit it @majidfeiz

@omalizadeh omalizadeh merged commit b23645c into omalizadeh:main Oct 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omalizadeh omalizadeh omalizadeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majidfeiz @omalizadeh