Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for https://github.com/electron-userland/electron-builder/pull/6201 #1

Merged
merged 2 commits into from
Dec 2, 2021
Merged

changes for https://github.com/electron-userland/electron-builder/pull/6201 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6aad2b5
use new app-builder-bin & hook up compression option
ppd Nov 28, 2021
52b70b1
set default snap compression type to lzo
ppd Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/app-builder-lib/scheme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5234,8 +5234,8 @@
"type": "null"
}
],
"default": "xz",
"description": "Sets the compression type for the snap. Can be xz or lzo. Defaults to xz when not specified."
"default": "lzo",
"description": "Sets the compression type for the snap. Can be xz or lzo. Defaults to lzo when not specified."
},
"useTemplateApp": {
"description": "Whether to use template snap. Defaults to `true` if `stagePackages` not specified.",
Expand Down
4 changes: 4 additions & 0 deletions packages/app-builder-lib/src/targets/snap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,10 @@ export default class SnapTarget extends Target {
if (this.isUseTemplateApp) {
args.push("--template-url", `electron4:${snapArch}`)
}

if (options.compression != null) {
args.push("--compression", options.compression)
}
await executeAppBuilder(args)

await packager.info.callArtifactBuildCompleted({
Expand Down
2 changes: 1 addition & 1 deletion packages/builder-util/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"7zip-bin": "~5.1.1",
"@types/debug": "^4.1.6",
"@types/fs-extra": "^9.0.11",
"app-builder-bin": "3.7.1",
"app-builder-bin": "4.1.0",
"bluebird-lst": "^1.0.9",
"builder-util-runtime": "workspace:*",
"chalk": "^4.1.1",
Expand Down
8 changes: 4 additions & 4 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.