Skip to content
This repository has been archived by the owner on Aug 23, 2021. It is now read-only.

Inconsistant Metrics Labels #337

Open
bialesdaniel opened this issue Sep 20, 2020 · 0 comments
Open

Inconsistant Metrics Labels #337

bialesdaniel opened this issue Sep 20, 2020 · 0 comments

Comments

@bialesdaniel
Copy link

The metric labels for the .summary file and the .res file look very different.
.res looks like this:

time(sec), throughput(req/sec), avg_lat(ms), min_lat(ms), 25th_lat(ms), median_lat(ms), 75th_lat(ms), 90th_lat(ms), 95th_lat(ms), 99th_lat(ms), max_lat(ms), tp (req/s) scaled

.summary looks like this:

public Map<String, Double> toMap() {
	Map<String, Double> distMap = new LinkedHashMap<String, Double>();
		distMap.put("Minimum Latency (milliseconds)", getMinimum() / 1e3);
		distMap.put("25th Percentile Latency (milliseconds)", get25thPercentile() / 1e3);
		distMap.put("Median Latency (milliseconds)", getMedian() / 1e3);
		distMap.put("Average Latency (milliseconds)", getAverage() / 1e3);
		distMap.put("75th Percentile Latency (milliseconds)", get75thPercentile() / 1e3);
		distMap.put("90th Percentile Latency (milliseconds)", get90thPercentile() / 1e3);
		distMap.put("95th Percentile Latency (milliseconds)", get95thPercentile() / 1e3);
		distMap.put("99th Percentile Latency (milliseconds)", get99thPercentile() / 1e3);
		distMap.put("Maximum Latency (milliseconds)", getMaximum() / 1e3);
		return distMap;
	}

Also, it seems like writeCSV2 is still using microseconds and I think it makes sense to stick with milliseconds since that is used elsewhere.

public void writeCSV2(int windowSizeSeconds, PrintStream out, TransactionType txType) {

I propose we use constants to standardize the labeling and the units

bialesdaniel added a commit to bialesdaniel/oltpbench that referenced this issue Sep 20, 2020
…bels. I'm not sure this is the lables that we want to use but at least they are stadardized across the files. Also I'm not sure if this breaks anything with Matlab.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant