Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caa records: convert bytes values to string #6

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

freym
Copy link

@freym freym commented Sep 12, 2024

dnspython returns the value and tag for caa records as bytes and octodns tries to set the string representation as values.

Example redacted output from octodns without this change:

********************************************************************************
* example.org.
********************************************************************************
* netbox (NetBoxDNSProvider)
*   Update
*     <CaaRecord CAA 300, example.org., ['0 issue "letsencrypt.org"']> ->
*     <CaaRecord CAA 300, example.org., ['0 b'issue' "b'letsencrypt.org'"']> (netbox)
*   Summary: Creates=0, Updates=1, Deletes=0, Existing Records=1
********************************************************************************

@olofvndrhr
Copy link
Owner

Looks good to me.
Personally never used it to sync CAA records, so thanks for the fix.

@olofvndrhr olofvndrhr merged commit 7b36a68 into olofvndrhr:main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants